[IGNITE-15439] [Ignite 3] Fix Errorprone errors in Raft module.

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 3.0.0-alpha3
• Labels: ignite-3
• Ignite Flags: Docs Required, Release Notes Required
• Assignee: Andrey Mashenkov
• Reporter: Andrey Mashenkov
• Reviewer: Alexey Scherbakov
• Created: 03/Sep/21 09:00
• Updated: 21/Sep/21 13:52
• Resolved: 21/Sep/21 13:52

Description

Static analyzer tool Errorprone reports errors for few modules.
These errors are muted and must be fixed.

Let's fix error in Raft module.

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project ignite-raft: Compilation failure
[ERROR] /home/amashenkov/work/apache-ignite-3/modules/raft/src/main/java/org/apache/ignite/raft/jraft/rpc/impl/AbstractClientService.java:[79,30] [CollectionIncompatibleType] Argument 'member.address()' should not be passed to this method; its type NetworkAddress is not compatible with its collection's type argument String
[ERROR]     (see https://errorprone.info/bugpattern/CollectionIncompatibleType)

See

 @Override public void onDisappeared(ClusterNode member) {
        readyAddresses.remove(member.address());
    }

Issue Links

• is caused by: IGNITE-15393 [Ignite 3] Add Errorprone static analyzer maven plugin
• links to: GitHub Pull Request #333
• links to: PR