[IGNITE-15264] DistributedConfigurationStorage violates MetaStorageManager watch contract

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha2
• Fix Version/s: 3.0.0-alpha3
• Labels: iep-55 ignite-3
• Epic Link: Configuration
• Assignee: Ivan Bessonov
• Reporter: Ivan Bessonov
• Reviewer: Mirza Aliev
• Created: 05/Aug/21 14:34
• Updated: 11/Aug/21 06:30
• Resolved: 11/Aug/21 06:30

Description

There are a few issues with the DistributedConfigurationStorage and related classes:

• MetaStorageManager#DISTRIBUTED_PREFIX is located in the wrong class;
• MetaStorageManager#APPLIED_REV constant should be changed;
• DistributedConfigurationStorage#MASTER_KEY is confused with APPLIED_REV in some places, so DistributedConfigurationStorage#readAll returns god knows what;
• watch callback in DistributedConfigurationStorage#registerConfigurationListener returns from onUpdate before notifications are processed. DistributedConfigurationStorage#notifyApplied doesn't work properly as well.

 

Issue Links

• links to: GitHub Pull Request #262