[IGNITE-15252] JmxMetricExporterSpi throws assertion error on a filtered metric unregister

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.12
• Release Note: Fix the AssertionError when the JmxMetricExporterSpi unregister a filtered metric registry
• Ignite Flags: Release Notes Required
• Assignee: Nikita Amelchev
• Reporter: Nikita Amelchev
• Created: 04/Aug/21 16:43
• Updated: 16/Dec/21 21:23
• Resolved: 05/Aug/21 06:27

Description

JmxMetricExporterSpi does not filter metrics when trying to remove a registry.

This produces the assertion error:

[2021-08-04 17:33:30,821][ERROR][disco-event-worker-#51%metric.JmxTest0%][IgniteTestResources] Critical system error detected. Will be handled accordingly to configured handler [hnd=NoOpFailureHandler [super=AbstractFailureHandler [ignoredFailureTypes=UnmodifiableSet [SYSTEM_WORKER_BLOCKED, SYSTEM_CRITICAL_OPERATION_TIMEOUT]]], failureCtx=FailureContext [type=SYSTEM_WORKER_TERMINATION, err=java.lang.AssertionError]]
java.lang.AssertionError
	at org.apache.ignite.spi.metric.jmx.JmxMetricExporterSpi.unregister(JmxMetricExporterSpi.java:110)
	at org.apache.ignite.internal.util.IgniteUtils.notifyListeners(IgniteUtils.java:11706)
	at org.apache.ignite.internal.processors.metric.GridMetricManager.lambda$remove$3(GridMetricManager.java:393)
	at java.util.concurrent.ConcurrentHashMap.computeIfPresent(ConcurrentHashMap.java:1769)
	at org.apache.ignite.internal.processors.metric.GridMetricManager.remove(GridMetricManager.java:391)
	at org.apache.ignite.internal.managers.GridManagerAdapter$1.removeMetricRegistry(GridManagerAdapter.java:634)
	at org.apache.ignite.spi.communication.tcp.TcpCommunicationMetricsListener.onNodeLeft(TcpCommunicationMetricsListener.java:403)
	at org.apache.ignite.spi.communication.tcp.TcpCommunicationSpi.onNodeLeft(TcpCommunicationSpi.java:2881)
	at org.apache.ignite.spi.communication.tcp.TcpCommunicationSpi$DiscoveryListener.onEvent(TcpCommunicationSpi.java:4800)
	at org.apache.ignite.internal.managers.eventstorage.GridEventStorageManager$LocalListenerWrapper.onEvent(GridEventStorageManager.java:1391)
	at org.apache.ignite.internal.managers.eventstorage.GridEventStorageManager.notifyListeners(GridEventStorageManager.java:886)
	at org.apache.ignite.internal.managers.eventstorage.GridEventStorageManager.notifyListeners(GridEventStorageManager.java:869)
	at org.apache.ignite.internal.managers.eventstorage.GridEventStorageManager.record0(GridEventStorageManager.java:346)
	at org.apache.ignite.internal.managers.eventstorage.GridEventStorageManager.record(GridEventStorageManager.java:309)
	at org.apache.ignite.internal.managers.discovery.GridDiscoveryManager$DiscoveryWorker.recordEvent(GridDiscoveryManager.java:2867)
	at org.apache.ignite.internal.managers.discovery.GridDiscoveryManager$DiscoveryWorker.body0(GridDiscoveryManager.java:3083)
	at org.apache.ignite.internal.managers.discovery.GridDiscoveryManager$DiscoveryWorker.body(GridDiscoveryManager.java:2887)
	at org.apache.ignite.internal.util.worker.GridWorker.run(GridWorker.java:120)
	at java.lang.Thread.run(Thread.java:748)

Issue Links

• links to: GitHub Pull Request #9300