[IGNITE-14153] TcpCommunicationSpi#closeStaleConnections() doesn't work for outgoing connections

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.9.1
• Fix Version/s: 2.11
• Component/s: networking
• Release Note: Fixed an issue when connection closed by the one node could lead to infinite connection attempts on the other node.
• Ignite Flags: Release Notes Required
• Assignee: Igor Belyakov
• Reporter: Igor Belyakov
• Reviewer: Sergey Chugunov
• Created: 10/Feb/21 10:07
• Updated: 18/Sep/21 23:00
• Resolved: 18/Feb/21 06:56

Description

Scenario:
1. Node1 established communication connection to Node2.
2. Due to network issue the connection was closed on Node2 side, but was still alive on Node1 side. (half-open connection)
3. At some point of time Node2 tries to send a message to Node1, and since there are no existing connections it creates a new one.
4. Node1 detects that it already has connection to Node2 and prints next message:
[TcpCommunicationSpi] Received incoming connection when already connected to this node, rejecting [locNode=2cc905e6-6666-48c1-b316-7652d6600001, rmtNode=44c537a7-6070-4272-a545-cff054b00000]
5. Node1 tries to close existing connection by using closeStaleConnection() method, but since the connection was outcoming it skipped due to "if (ses0.accepted())" check.
6. Node2 makes an infinite amount of tries to connect without success.

Reproducer is attached.

Issue Links

• links to: GitHub Pull Request #8788