[IGNITE-13588] .NET: Incorrect binary type name is registered for generic query types

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.9, 2.8.1
• Fix Version/s: 2.11
• Component/s: platforms
• Labels: .NET 2.9.1-rc

Environment

Apache Ignite: v2.8.1

JDK: v1.8

.NET Core: v3.1

• Release Note: .NET: Fixed SQL type name for generic query types
• Ignite Flags: Docs Required, Release Notes Required
• Assignee: Pavel Tupitsyn
• Reporter: Danut Radoaica
• Created: 16/Oct/20 13:28
• Updated: 03/Feb/21 01:29
• Resolved: 27/Jan/21 14:10

Description

Using a generic type as a QueryEntity value type results in a wrong type name being registered in QueryEntities and a wrong typeId being calculated for the binary metadata:

            var ignite = Ignition.Start(TestUtils.GetTestConfiguration());

            var cfg = new CacheConfiguration(TestUtils.TestName)
            {
                QueryEntities = new[] {new QueryEntity(typeof(int), typeof(GenericTest<string>))}
            };

            var cache = ignite.GetOrCreateCache<int, GenericTest<string>>(cfg);
            cache[1] = new GenericTest<string> {Prop = "foo"};

            var binType = ignite.GetBinary().GetBinaryTypes().Single();

            Assert.AreEqual(-590542188, binType.TypeId); // 945954881 with QueryEntity
            Assert.AreEqual(
                "Apache.Ignite.Core.Tests.Cache.Query.CacheQueriesCodeConfigurationTest+GenericTest`1[[System.String]]",
                cache.GetConfiguration().QueryEntities.Single().ValueTypeName); // Includes assembly name with query entity

BinaryUtils.GetSqlTypeName returns Type.FullName, which includes assembly-qualified type names for all generic type arguments.
This causes the following problems:

• SQL type name includes assembly versions, so queries stop working if there is a version change
• Incorrect binary type id is registered, because due to IGNITE-13160 changes the string from BinaryUtils.GetSqlTypeName gets passed back to UnmanagedCallbacks.BinaryTypeGet

Issue Links

• is caused by: IGNITE-13160 .NET: wrong affinity key registration with AffinityKeyMapped attribute
• is related to: IGNITE-14064 .NET: Incorrect table name when query type is generic
• links to: GitHub Pull Request #8392
• links to: GitHub Pull Request #8708