[IGNITE-13014] Remove double checking of node availability.

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Invalid
• Ignite Flags: Release Notes Required
• Assignee: Vladimir Steshin
• Reporter: Vladimir Steshin
• Created: 15/May/20 09:37
• Updated: 06/Aug/20 10:16
• Resolved: 05/Jun/20 10:55

Description

Proposal:
Do not check failed node second time. Double node checking prolongs node failure detection and gives no additional benefits. There are mesh and hardcoded values in this routine.

For the present, we have double checking of node availability. Let's imagine node 2 doesn't answer any more. Node 1 becomes unable to ping node 2 and asks Node 3 to establish permanent connection instead of node 2. Node 3 may try to check node 2 too. Or may not.

Possible long detection of node failure up to ServerImpl.CON_CHECK_INTERVAL + 2 * IgniteConfiguretion.failureDetectionTimeout + 300ms.

See:

• ‘NodeFailureResearch.patch'. It creates test 'FailureDetectionResearch' which emulates long answears on a failed node and measures failure detection delays.
• 'FailureDetectionResearch.txt' - results of the test.
• 'WostCaseStepByStep.txt' - description how the worst case happens.

Issue Links

• causes: IGNITE-13111 Simplify backward checking of node connection.
• depends upon: IGNITE-13016 Fix backward checking of failed node.
• is duplicated by: IGNITE-13018 Get rid of duplicated checking of failed node.
• links to: GitHub Pull Request #7869
• links to: GitHub Pull Request #7869

Sub-Tasks

• Fix backward checking of failed node.: Resolved
• Remove hardcoded delay from re-marking failed node as alive.: Resolved
• Get rid of duplicated checking of failed node.: Resolved