[IGNITE-12665] SQL: Potential race on MapResult close.

• Type: Task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.9, 2.8.1
• Component/s: sql
• Labels: refactoring
• Assignee: Andrey Mashenkov
• Reporter: Andrey Mashenkov
• Created: 12/Feb/20 11:10
• Updated: 17/Apr/20 07:45
• Resolved: 13/Feb/20 09:35

Description

Seems, a race possible on MapQueryResult*s*.close() as this code can be called twice.

Let's rewrite it make sure every map result is closed via MapQueryResult*s*.closeResult(int) method only.
Then allow cleanup once all map results are closed.
Then MapQueryResult*s*.allClosed() can be optimized as we always know number of map results and all map results are closed via MapQueryResult*s* instance.

Seems, MepQueryExecutor.onQueryRequest0() has dead code. See "res.openResult(rs)" call when 'null' passed as argument.

 

Start point is MapQueryResult.openResult(res). 

 

Issue Links

• links to: GitHub Pull Request #7414