[IGNITE-11036] IgniteTcpCommunicationHandshakeWaitTest/IgniteTcpCommunicationHandshakeWaitSslTest fail in master

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.8
• Fix Version/s: 2.8
• Labels: MakeTeamcityGreenAgain
• Assignee: Sergey Kosarev
• Reporter: Sergey Kosarev
• Created: 23/Jan/19 07:44
• Updated: 23/Jan/19 08:53
• Resolved: 23/Jan/19 08:49

Description

On my local environment (Mac OS X) IgniteTcpCommunicationHandshakeWaitSslTest fails in 100% rate.

junit.framework.AssertionFailedError: 
Expected :3
Actual   :1
 <Click to see difference>
	at junit.framework.Assert.assertEquals(Assert.java:241)
	at org.apache.ignite.spi.communication.tcp.IgniteTcpCommunicationHandshakeWaitTest.lambda$testHandshakeOnNodeJoining$0(IgniteTcpCommunicationHandshakeWaitTest.java:99)
	at org.apache.ignite.testframework.GridTestUtils.lambda$runAsync$2(GridTestUtils.java:1009)

I've investigated and found that the test overrides TcpDiscoverySpi but does not set ipFinder to the new object. Setting ipFinder solves the problem.

Issue Links

• links to: GitHub Pull Request #5894
• links to: TC Run SPI