[IGNITE-10988] Zookeeper test case testCommunicationFailureResolve_KillRandom frequently fails in GridAbstractTest.waitForTopology

• Type: Bug
• Status: In Progress
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 2.7
• Labels: MakeTeamcityGreenAgain
• Assignee: Ivan Daschinsky
• Reporter: Oleg Ignatenko
• Created: 18/Jan/19 15:27
• Updated: 21/Oct/20 21:01

Description

Zookeeper test case testCommunicationFailureResolve_KillRandom frequently fails in GridAbstractTest.waitForTopology.

Teamcity test history in master currently shows "Test runs: 625 total / 251 failures" ([link|https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8&testNameId=-3849782382784091413&tab=testDetails).

Need to find out why is that and whether test case can be improved and made more reliable.

Typical failure message looks as follows:

[2019-01-18 06:57:23,489][ERROR][main][root] Test failed.
junit.framework.AssertionFailedError
	at junit.framework.Assert.fail(Assert.java:55)
	at junit.framework.Assert.assertTrue(Assert.java:22)
	at junit.framework.Assert.assertTrue(Assert.java:31)
	at org.apache.ignite.testframework.junits.GridAbstractTest.waitForTopology(GridAbstractTest.java:2294)
	at org.apache.ignite.spi.discovery.zk.internal.ZookeeperDiscoverySpiTest.waitForTopology(ZookeeperDiscoverySpiTest.java:5103)
	at org.apache.ignite.spi.discovery.zk.internal.ZookeeperDiscoverySpiTest.testCommunicationFailureResolve_KillRandom(ZookeeperDiscoverySpiTest.java:3145)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.apache.ignite.testframework.junits.GridAbstractTest$6.run(GridAbstractTest.java:2088)
	at java.lang.Thread.run(Thread.java:748)

---

Side note per IGNITE-10777 this test case has moved to another class, from ZookeeperDiscoverySpiTest to ZookeeperDiscoverySpiTest5 (which was further renamed to ZookeeperDiscoveryCommunicationFailureTest) but that didn't change anything: it still fails frequently and failure message is the same, with the only difference in the new test class name.

Issue Links

• is broken by: IGNITE-9493 Communication error resolver shouldn't be invoked if connection with client breaks unexpectedly
• is related to: IGNITE-10777 Cleanup remainders of JUnit4TestAdapter and other JUnit 3 API involving test suites