Uploaded image for project: 'Ignite'
  1. Ignite
  2. IGNITE-10698

Get rid of @MXBeanParametersNames and @MXBeanParametersDescriptions

    XMLWordPrintableJSON

    Details

    • Type: Task
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 3.0
    • Component/s: None
    • Labels:
    • Ignite Flags:
      Docs Required

      Description

      @MXBeanDescription("Returns or kills transactions matching the filter conditions.")
          @MXBeanParametersNames(
              {
                  "minDuration",
                  "minSize",
                  "prj",
                  "consistentIds",
                  "xid",
                  "lbRegex",
                  "limit",
                  "order",
                  "detailed",
                  "kill"
              }
          )
          @MXBeanParametersDescriptions(
              {
                  "Minimum duration (seconds).",
                  "Minimum size.",
                  "Projection (servers|clients).",
                  "Consistent ids (separated by comma).",
                  "Transaction XID.",
                  "Label regexp.",
                  "Limit a number of transactions collected on each node.",
                  "Order by DURATION|SIZE.",
                  "Show detailed description, otherwise only count.",
                  "Kill matching transactions (be careful)."
              }
          )
      

      Above looks pretty ugly and is very error prone due to messing names and descr order or number of strings.

      I would suggest to introduce individual parameters annotations and get them via mtd.getParamterAnnotations() at runtime.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              yzhdanov Yakov Zhdanov
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: