[IGNITE-10450] In Ignite code style inspections increase level for those used at Teamcity build checks

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Done
• Affects Version/s: 2.6
• Labels: MakeTeamcityGreenAgain
• Assignee: Oleg Ignatenko
• Reporter: Oleg Ignatenko
• Created: 28/Nov/18 16:09
• Updated: 12/Dec/18 08:55
• Resolved: 12/Dec/18 08:55

Description

Some of Ignite code style inspections are verified at Teamcity per IGNITE-9983. (Currently TC inspections are "SizeReplaceableByIsEmpty", "UnusedImport", "MissingOverrideAnnotation", "MissortedModifiers", "RedundantSuppression".)

Per discussion of issue IGNITE-10399 it looks like there is a room for improvement here. Specifically, the problem occurred because it was too difficult to find a new deviation that made TC inspections check fail because it was buried among multiple similar looking but non-critical deviations in a particular piece of old code (PageMemoryImpl.java).

It would be more convenient if programmer could easier see subset of checks that are used at Teamcity because this would allow to fix these earlier and avoid cumbersome TC runs and failure reports analysis.

Technically this could be achieved by editing inspections config file and increasing respective inspections level to ERROR. I briefly checked how it would work in a "sandbox" project on my machine and it looked quite convenient: violations of inspections used by TC were shown as red in Error Stripe while the rest remained yellow, easy to see. (It's probably not very important but for the sake of completeness a thing I noticed when testing is that having red inspections didn't block compilation and execution of the code.) Screen shot of how it worked in my experiment is attached: IDEA.inspections.TC-bot.png

Issue Links

• Is contained by: IGNITE-10422 Make {{ignite_inspection.xml}} configuration default on the project level
• is related to: IGNITE-10399 Fix inspection failures
• is related to: IGNITE-9983 Add an inspection configuration for TC suite with enabled short list of rules
• is related to: IGNITE-10227 Update unused imports TC configuration of inspection profile