[IGNITE-10191] Incorrect comparison of lists in RendezvousAffinityFunctionSimpleBenchmark#testAffinityCompatibility

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.6
• Fix Version/s: 2.8
• Labels: MakeTeamcityGreenAgain
• Assignee: Oleg Ignatenko
• Reporter: Oleg Ignatenko
• Created: 08/Nov/18 15:03
• Updated: 22/Nov/18 16:20
• Resolved: 22/Nov/18 16:17

Description

RendezvousAffinityFunctionSimpleBenchmark#testAffinityCompatibility (in current codebase muted by renaming to _testAffinityCompatibility) looks troublesome: apparent bug is incorrect comparison of lists expecting elements to be always in the same order which doesn't look like the case for the tested API:

            List<List<ClusterNode>> assignment0 = assignPartitions(aff0, nodes, null, backups, 0).get2();

                  List<List<ClusterNode>> assignment1 = assignPartitions(aff1, nodes, null, backups, 0).get2();

                  assertEquals (assignment0, assignment1);

Though test kept failing even after I experimented with replacing comparison to one that was insensitive to the order of list elements.

Brief checking of code intended to be tested suggests that maybe it isn't even supposed to be deterministic - in case if this is correct test should be very thoroughly redesigned.

Issue Links

• links to: GitHub Pull Request #5460
• links to: Upsource review