[IGNITE-10158] Some tests in IgniteCacheAbstractQuerySelfTest are incorrectly muted

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.6
• Fix Version/s: 2.8
• Labels: MakeTeamcityGreenAgain
• Assignee: Oleg Ignatenko
• Reporter: Oleg Ignatenko
• Created: 07/Nov/18 11:23
• Updated: 27/Nov/18 17:08
• Resolved: 27/Nov/18 17:04

Description

Some tests in IgniteCacheAbstractQuerySelfTest are muted by renaming (prefixing with underscore, _test... and refer invalid JIRA URL in fail parameter ("http://atlassian.gridgain.com/jira/browse/GG-11216").

• _testDifferentKeyTypes
  this test should change expectation to opposite and after that recovered
• _testObjectQueryWithSwap and _testTwoObjectsTextSearch
  Need to be properly muted and further investigated, per separate tickets. Per my preliminary checks tests fail because
  of wrong cache configuration, although there is also a chance that test design is wrong and these should be deleted.

There is also a dead code there, a private class EmptyObject - it needs to be deleted. Code that was using this class was removed per IGNITE-1232 (commit 79b8b08) but this private class was forgotten.

I also searched project code for other occurrences of mentioned troublesome fail parameter "GG-11216" and found yet another incorrectly muted test: IgniteCacheQueryMultiThreadedSelfTest#_testMultiThreadedSwapUnswapLongString
This test should be recovered. It passed on my machine and per my comparison with similar test cases testMultiThreadedSwapUnswapLong and testMultiThreadedSwapUnswapString its design looks fairly reasonable.

Issue Links

• depends upon: IGNITE-10159 IgniteCacheAbstractQuerySelfTest.testObjectQueryWithSwap fails non-null assertion at localPeek
• depends upon: IGNITE-10162 IgniteCacheAtomicQuerySelfTest#testTwoObjectsTextSearch fails with IgniteCheckedException: Failed to find SQL table for type: ObjectValue
• links to: GitHub Pull Request #5344
• links to: Upsource review