[IBATISNET-262] Refactor duplicate code for opening session into DataMapperLocalSessionScope

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: DataMapper 3.0
• Fix Version/s: DataMapper 3.0
• Assignee: Gilles Bayon
• Reporter: liu ron
• Created: 17/May/08 19:03
• Updated: 18/May/08 07:21
• Resolved: 18/May/08 07:21

Description

Move duplicate code for creating the local session into a class level scope that has access to the private members of DataMapper:

private class DataMapperLocalSessionScope : IDisposable
{
private readonly ISession session;
private readonly bool isSessionLocal = false;

public DataMapperLocalSessionScope(DataMapper dataMapper)
{
isSessionLocal = false;
session = dataMapper.sessionStore.CurrentSession;

if (session == null)

{ session = dataMapper.sessionFactory.OpenSession(); isSessionLocal = true; }

}

public ISession Session
{
get

{ return session; }

}

public void Dispose()
{
if (isSessionLocal)

{ session.Close(); }

}
}

to avoid duplicating code across 22 methods. The code in each of the Query... methods is now much shorter:

public IList QueryForList(string statementId, object parameterObject)
{
using (DataMapperLocalSessionScope sessionScope = new DataMapperLocalSessionScope(this))

{ IMappedStatement statement = modelStore.GetMappedStatement(statementId); return statement.ExecuteQueryForList(sessionScope.Session, parameterObject); }

}