[IBATISNET-234] typeAlias does not work for generics with 2 or more generic parameters

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: DataMapper 1.6.1
• Fix Version/s: DataMapper 1.6.2
• Component/s: DataMapper
• Environment: .Net 2
• Assignee: Gilles Bayon
• Reporter: Roaan Vos
• Created: 30/Jul/07 21:21
• Updated: 15/Sep/07 17:35
• Resolved: 15/Sep/07 17:35

Description

The typeresolver does not work with generic types that takes 2 (or more) generic parameters.
The problem lies in the "SplitTypeAndAssemblyNames" method of the "TypeAssemblyInfo" class.

The follow is a fix

================ CUT ==========================
private void SplitTypeAndAssemblyNames(string originalTypeName)
{
if (originalTypeName.StartsWith(TypeAssemblyInfo.NULLABLE_TYPE))
{
int typeAssemblyIndex = originalTypeName.LastIndexOf(TypeAssemblyInfo.NULLABLE_TYPE_ASSEMBLY_SEPARATOR);
if (typeAssemblyIndex < 0)

{ _unresolvedTypeName = originalTypeName; }
else
{ _unresolvedTypeName = originalTypeName.Substring(0, typeAssemblyIndex + 2).Trim(); _unresolvedAssemblyName = originalTypeName.Substring(typeAssemblyIndex + 3).Trim(); }
}
else
{
int typeAssemblyIndex = originalTypeName.LastIndexOf(TYPE_ASSEMBLY_SEPARATOR);
if (typeAssemblyIndex < 0)
{ _unresolvedTypeName = originalTypeName; }

else

{ _unresolvedTypeName = originalTypeName.Substring(0, typeAssemblyIndex).Trim(); _unresolvedAssemblyName = originalTypeName.Substring(typeAssemblyIndex + 1).Trim(); }

}
}
======================= CUT =========================

Note that I changed the ".IndexOf(TYPE_ASSEMBLY_SEPARATOR)" to
".LastIndexOf(TYPE_ASSEMBLY_SEPARATOR)"

Not a brilliant fix, but I think it will do