[IBATISNET-158] TypeAssemblyInfo.SplitTypeAndAssemblyNames

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: DataMapper 1.3
• Fix Version/s: DataMapper 1.5
• Component/s: DataMapper
• Assignee: Gilles Bayon
• Reporter: Chris Potter
• Created: 17/May/06 22:31
• Updated: 01/Jun/06 12:30
• Resolved: 21/May/06 04:56

Description

Hi All:

I'd like to propose a change to the TypeAssemblyInfo internal class within TypeResolver.cs. Please see the proposed code change below.

private void SplitTypeAndAssemblyNames (string originalTypeName)

{

int typeAssemblyIndex

// Original Code = originalTypeName.IndexOf (

= originalTypeName.LastIndexOf (

TypeAssemblyInfo.TypeAssemblySeparator);

if (typeAssemblyIndex < 0)

{ unresolvedTypeName = originalTypeName; }

else

{ unresolvedTypeName = originalTypeName.Substring ( 0, typeAssemblyIndex).Trim (); unresolvedAssemblyName = originalTypeName.Substring ( typeAssemblyIndex + 1).Trim (); }

}

Changing the call from IndexOf to LastIndexOf allows me to define a .Net 2.0 generic in the listClass attribute of a statement definition. You can see an example below. This syntax is impropertly parsed for a comma without this proposed change.

<select id="LoadCodesByCategory" parameterMap="CodeData.CodeDataByCategoryParams" resultMap="LoadStateCode" listClass="System.Collections.Generic.List`1[[NFS.Data.Core.DataObjects.Impl.StateCode, NFS.Data.Impl]], mscorlib">