[IBATIS-359] Performance Improvement when No SecurityManager installed

• Type: New Feature
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.8, 2.0.9, 2.0.9b, 2.1.0, 2.1.5, 2.1.6, 2.1.7, 2.2.0, 2.3.0
• Fix Version/s: 2.3.1
• Component/s: Core
• Environment: Linux/Windows
• Assignee: Unassigned
• Reporter: Philippe Mouawad
• Created: 23/Oct/06 21:03
• Updated: 15/Aug/09 13:43
• Resolved: 06/May/07 12:19

Description

In class com.ibatis.common.beans.ClassInfo, when NO SecurityManager is installed, each time the method ClassInfo#canAccessPrivateMethods() is called, a NullPointer exception is thrown, it would be more performant to test for nullity:

private boolean canAccessPrivateMethods() {
try {
SecurityManager manager = System.getSecurityManager();
if (manager == null)

{ return true; }

manager.checkPermission(new ReflectPermission("suppressAccessChecks"));
return true;
} catch (SecurityException e)

{ return false; }

catch (NullPointerException e)

{ return true; }

}