Uploaded image for project: 'Apache Hudi'
  1. Apache Hudi
  2. HUDI-7879

Optimize the redundant creation of HoodieTable in DataSourceInternalWriterHelper and the unnecessary parameters in createTable within BaseHoodieWriteClient.

Log workAgile BoardRank to TopRank to BottomAttach filesAttach ScreenshotBulk Copy AttachmentsBulk Move AttachmentsVotersWatch issueWatchersCreate sub-taskConvert to sub-taskLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.16.0
    • None

    Description

      In the initialization method of DataSourceInternalWriterHelper, it currently creates two identical HoodieTable instances. We should remove one of them. Also, when comparing the differences between the two HoodieTable instances, I noticed that the createTable method in BaseHoodieWriteClient includes a HadoopConfiguration parameter that isn't used by any implemented methods. I'm not sure why it was designed this way, but I think we can remove it.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned Assign to me
            majian Ma Jian
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment