[HUDI-6930] Eliminate the shouldLock flag for TimeGenerator(phase2)

• Type: Improvement
• Status: Open
• Priority: Critical
• Resolution: Unresolved
• Fix Version/s: 1.1.0
• Component/s: core
• Story Points: 4
• Epic Link: 1.X Api & Abstractions
• Assignee: Danny Chen
• Reporter: Danny Chen
• Created: 10/Oct/23 03:29
• Updated: 5 days ago 18:44

Description

In HUDI-1623, we introduced the TimeGenerator, but left a shouldLock flag on the interfaces which increases the complexity for maintainance.
Basically, we need to make the lock provider as reentrant to alleviate the situration.

Several ideas here (aborted):

1. introduces the isLocked interface on the LockProvider and uses that to decide on whether we need a separate lock for the TimeGenerator (disapproved because this method has no guarantee of atomicity)

2. create temporary marker files for passing the flag (does not midiate the complexity, the caller stills needs to care about whether we should add lock or not)
3. set the shouldLock flag into the TimeGenerator instance (same as 2, does not really soves the problem)