[HUDI-5731] Fix com.google.common classes still being relocated in Hudi Spark bundle

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 0.12.1
• Fix Version/s: 0.14.0
• Labels: pull-request-available
• Assignee: Alexey Kudinkin
• Reporter: dzcxzl
• Created: 08/Feb/23 13:28
• Updated: 23/May/23 05:34
• Resolved: 09/Feb/23 16:45

Description

As originally reported in:

https://github.com/apache/hudi/pull/6240#issuecomment-1420149952

 

The issue have been that after removal of Guava we still kept following relocations configs in MR/Spark bundles:

<relocation>
  <pattern>com.google.common.</pattern>
  <shadedPattern>org.apache.hudi.com.google.common.</shadedPattern>
</relocation> 

Which in turn meant that all references from any class referencing Guava would be shaded, even though Hudi isn't packaging Guava anymore. This might result in following exception:

Caused by: java.lang.NoClassDefFoundError: org/apache/hudi/com/google/common/base/Preconditions
	at org.apache.curator.ensemble.fixed.FixedEnsembleProvider.<init>(FixedEnsembleProvider.java:39)
	at org.apache.curator.framework.CuratorFrameworkFactory$Builder.connectString(CuratorFrameworkFactory.java:193)
	at org.apache.kyuubi.ha.client.zookeeper.ZookeeperClientProvider$.buildZookeeperClient(ZookeeperClientProvider.scala:62)
	at org.apache.kyuubi.ha.client.zookeeper.ZookeeperDiscoveryClient.<init>(ZookeeperDiscoveryClient.scala:65)
	... 45 more 

Issue Links

• is broken by: HUDI-4482 Remove guava from codebase
• links to: GitHub Pull Request #7898
• links to: GitHub Pull Request #7900