[HUDI-402] Code clean up in DataSourceUtils.java and all test classes

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.5.1
• Component/s: code-quality
• Labels: pull-request-available
• Assignee: Pratyaksh Sharma
• Reporter: Pratyaksh Sharma
• Created: 12/Dec/19 07:55
• Updated: 31/Dec/19 20:09
• Resolved: 31/Dec/19 20:09

Description

DataSourceUtils.java - 

In function getNestedFieldValAsString, we call getNestedFieldVal function to get the value. Then we check if the object returned is null, which is always false, since the called function throws an exception rather than returning null. 

Need to change the code accordingly.

Test classes - 

1. We have defined checked exceptions at a lot of places which are actually not thrown anywhere. 
2. Similarly, java stream code can be refactored at a lot of places. 

Issue Links

• links to: GitHub Pull Request #1153