[HTTPCORE-91] bad constant names in o.a.h.protocol.HTTP

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 4.0-alpha5
• Fix Version/s: 4.0-alpha6
• Component/s: HttpCore
• Assignee: Roland Weber
• Reporter: Roland Weber
• Created: 12/Jul/07 10:53
• Updated: 13/Jul/07 13:35
• Resolved: 13/Jul/07 13:35

Description

Class org.apache.http.protocol.HTTP defines some constants with inappropriate names:

public static final String DATE_DIRECTIVE = "Date";
public static final String SERVER_DIRECTIVE = "Server";

neither of these is a "directive" in any way. They are plain, informational headers.

public static final String EXPECT_DIRECTIVE = "Expect";
public static final String CONN_DIRECTIVE = "Connection";

While these are not termed "directive" in RFC 2616, they do have that character.

I suggest to rename DATE_DIRECTIVE and SERVER_DIRECTIVE to *_HEADER or *_INFO.
Within core, this would affect o.a.h.protocol, related tests, and NIO example NHttpReverseProxy.

cheers,
Roland