[HTTPCORE-735] "Connection pool shut down" unreasonable

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Invalid
• Component/s: HttpCore
• Assignee: Unassigned
• Reporter: qxo
• Created: 25/Feb/23 03:53
• Updated: 27/Feb/23 07:31
• Resolved: 25/Feb/23 08:52

Description

Why shutdown Connection pool if has a Error ?

This is very unreasonable, one application shares the same httpclient,

and a problem with one call will make the entire application unusable.

Not robust enough!!!

demo code: https://github.com/qxo/httpclient-shutdown-demo/blob/main/src/main/java/demo/HttpClientStackOverflowErrorShutdownDemo.java

21:54:21.921 [main] INFO  d.HttpClientStackOverflowErrorShutdownDemo - ==============================>invokeCount1: 1330
21:54:21.921 [main] ERROR d.HttpClientStackOverflowErrorShutdownDemo - java.lang.StackOverflowError
21:54:21.921 [main] INFO  d.HttpClientStackOverflowErrorShutdownDemo - ==============================>invokeCount2: 1330
Exception in thread "main" java.lang.IllegalStateException: Connection pool shut down
    at org.apache.http.util.Asserts.check(Asserts.java:34)
    at org.apache.http.pool.AbstractConnPool.lease(AbstractConnPool.java:191)
    at org.apache.http.impl.conn.PoolingHttpClientConnectionManager.requestConnection(PoolingHttpClientConnectionManager.java:267)
    at org.apache.http.impl.execchain.MainClientExec.execute(MainClientExec.java:176)
    at org.apache.http.impl.execchain.ProtocolExec.execute(ProtocolExec.java:185)
    at org.apache.http.impl.execchain.RetryExec.execute(RetryExec.java:89)
    at org.apache.http.impl.execchain.RedirectExec.execute(RedirectExec.java:110)
    at org.apache.http.impl.client.InternalHttpClient.doExecute(InternalHttpClient.java:185)
    at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:83)
    at org.apache.http.impl.client.CloseableHttpClient.execute(CloseableHttpClient.java:108)
    at demo.HttpClientStackOverflowErrorShutdownDemo.doGet(HttpClientStackOverflowErrorShutdownDemo.java:80)
    at demo.HttpClientStackOverflowErrorShutdownDemo.doLoopGet(HttpClientStackOverflowErrorShutdownDemo.java:65)
    at demo.HttpClientStackOverflowErrorShutdownDemo.main(HttpClientStackOverflowErrorShutdownDemo.java:51)
 

Issue Links

• is caused by: HTTPCLIENT-1924 connection leak issue when OutOfMemory