[HTTPCORE-709] BasicHttpRequest throws IllegalArgumentException for path starting with multiple slashes with authority

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Invalid
• Affects Version/s: 5.0.1, 5.1.1, 5.1.2, 5.1.3, 5.1, 5.2-alpha1, 5.2-alpha2
• Component/s: HttpCore
• Flags: Important
• Assignee: Unassigned
• Reporter: Jovan Attisha
• Created: 04/Mar/22 21:36
• Updated: 07/Mar/22 15:55
• Resolved: 07/Mar/22 15:55

Description

This commit to BasicHttpRequest attempts to make BasicHttpRequest conform to RFC3986, but I actually don't think this is properly following spec. The RFC says that:
If a URI contains an authority component, then the path component must either be empty or begin with a slash ("/") character. If a URI does not contain an authority component, then the path cannot begin with two slash characters ("//").
However, the code blocks a double slash no matter what, even if there is an authority component. So calling:

new BasicHttpRequest("GET", new URI("https://google.com//"));

throws an IllegalArgumentException.