[HTTPCORE-481] Early response suspends output even when response status is not error

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.4.5
• Fix Version/s: 4.4.7
• Component/s: HttpCore NIO
• Flags: Patch
• Assignee: Oleg Kalnichevski
• Reporter: Tuomas Kiviaho
• Created: 08/Aug/17 09:09
• Updated: 11/Aug/17 15:33
• Resolved: 11/Aug/17 15:33

Description

I have a text/event-stream response where status code 200 is sent immediately back even when there is still request body streaming in process. This works well with Jetty client but for some reason I could only receive the first full buffer at server side when switching over to HttpAsyncClient. The only visible notion that something went wrong was Jetty doing an idle timeout cleanup. Luckily there is a notion of connection state which got invalidated when response was received but only when request body streaming was still in progress.

I found out via this link https://stackoverflow.com/questions/14250991/is-it-acceptable-for-a-server-to-send-a-http-response-before-the-entire-request that probably the reason behind the behavior is to prevent flooding the server in case of an error.

An HTTP/1.1 (or later) client sending a message-body SHOULD monitor the network connection for an error status while it is transmitting the request. If the client sees an error status, it SHOULD immediately cease transmitting the body.

Below is a patch that currently functions as a work-a-round for me. I'd still prefer the current behavior in case of unauthorized authentication etc. because the request body can be quite large.

org/apache/http/nio/protocol/HttpAsyncRequestExecutor.java:295

         } else if (state.getRequestState() == MessageState.BODY_STREAM) {
             // Early response
+            if (statusCode >= 400) {
                conn.resetOutput();
                conn.suspendOutput();
                state.setRequestState(MessageState.COMPLETED);
                state.invalidate();
+            }
         }