[HTTPCORE-380] Support for HTTP Delete with entity body

• Type: New Feature
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.4-alpha1
• Fix Version/s: 5.0-alpha1
• Component/s: HttpCore, HttpCore NIO
• Assignee: Unassigned
• Reporter: Jeewantha Dharmaparakrama
• Created: 07/May/14 07:01
• Updated: 25/Nov/16 13:02
• Resolved: 26/Nov/14 20:35

Description

Hi All,

I have created a fix to support HTTP DELETEs with entity bodies. In HTTP Core, the HttpRequest object (BasicHttpRequest or BasicHttpEntityEnclosingRequest) is made by looking at the HTTP method. But sometimes an API could accept HTTP Deletes with payloads for example [1]. To support this I have introduced a new type of HTTP requests "HttpEntityPossibleEnclosingRequest". By calling the "getFinalHttpRequest" method in this class, the proper HTTP request object can be made, i.e. HttpRequest or HttpEntityEnclosingRequest. The logic is if the HttpEntityPossibleEnclosingRequest has the CONTENT_LENGTH header, an HttpEntityEnclosingRequest is made and an HttpRequest is made otherwise.

Note. the spec does not prohibit an HTTP Delete having a payload [2] [3].

[1] http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/docs-delete-by-query.html
[2] http://stackoverflow.com/a/299696/1411653
[3] http://www.w3.org/Protocols/rfc2616/rfc2616-sec9.html#sec9.7

Thanks,
Jeewantha