[HTTPCORE-313] ContentType.create(final String mimeType, final String charset) uncaught exception when charset == ""

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.2.1
• Fix Version/s: 4.2.3, 4.3-alpha1
• Component/s: HttpCore
• Environment: Ubuntu 12.04 LTS with openjdk-7
• Assignee: Unassigned
• Reporter: Guillaume Castagnino
• Created: 19/Sep/12 13:24
• Updated: 05/Oct/13 20:09
• Resolved: 20/Sep/12 19:29

Description

I parse a broken HTTP response from a server that replies with a crafted Content-Type header:
Content-Type: text/html; charset=

charset is present, but is empty. When using the EntityUtils.toString method, this triggers an uncaught exception in ContentType.create.
Indeed, it calls this:
return create(mimeType, charset != null ? Charset.forName(charset) : null);

charset is checked against the null value. But the empty string is not checked.
Charset.forName("") throws a "java.nio.charset.IllegalCharsetNameException" exception which is not caught whereas Charset.forName("broken") throws a "java.nio.charset.UnsupportedCharsetException" exception, which is correctly handled.

So I think that the empty string should be checked and managed like the null, isn't it ?