[HTTPCORE-312] LengthDelimitedEncoder fails on content length > 32 bit

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 4.2
• Fix Version/s: 4.2.2
• Component/s: HttpCore NIO
• Assignee: Unassigned
• Reporter: Roland Hänel
• Created: 17/Sep/12 16:08
• Updated: 05/Oct/13 20:09
• Resolved: 18/Sep/12 19:03

Description

The LengthDelimitedEncoder class fails to deliver contents that are larger than 2GB, because the write(final ByteBuffer src) method incorrectly calculates

int lenRemaining = (int) (this.contentLength - this.len);

For example, if this.contentLength is 3,000,000,000 and this.len is 0, then lenRemaining will be negative and things will go wrong in the process.

Changing the line to

long lenRemaining = this.contentLength - this.len;

will fix this bug (maybe src.remaining() needs to be casted to (long) in the following if statement).