[HTTPCORE-246] ThrottlingHttpClientHandler triggers EventListener.connectionClosed twice

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.1
• Fix Version/s: 4.1.1
• Component/s: HttpCore NIO
• Environment: Linux 2.6.32-26-generic #47-Ubuntu
• Assignee: Unassigned
• Reporter: Bryan Pon
• Created: 09/Dec/10 23:54
• Updated: 10/Dec/10 20:01
• Resolved: 10/Dec/10 11:39

Description

In ThrottlingHttpClientHandler.closed(NHttpClientConnection), connectionClosed() is called twice on the event listener:

if (this.eventListener != null)

{ this.eventListener.connectionClosed(conn); }

this.execHandler.finalizeContext(context);

if (this.eventListener != null) { this.eventListener.connectionClosed(conn); }

I'm not sure if this is intentional (looks unlikely), but I have a use case where this causes problems. I want to start a new connection whenever one is closed, so in the EventListener.connectionClosed() method I am invoking ConnectingIOReactor.connect(). Since connectionClosed() is triggered twice, this is opening two new connections. I can work around the issue by checking if connectionClosed() has already been called.