Uploaded image for project: 'HttpComponents HttpCore'
  1. HttpComponents HttpCore
  2. HTTPCORE-223

Thread-safety improvements

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 5.0-alpha1
    • HttpCore
    • None

    Description

      Thread-safety / isolation improvements to be considered for version 5.0
      ========================================================

      AbstractHttpEntity
      has 3 protected fields, however there are public getters/setters for
      all of the fields, so it seems to me that the fields should be
      private. That would allow synch. to be added later if necessary.

      HttpEntityWrapper

      • wrappedEntity should be final.

      AbstractHttpMessage

      • headerGroup should be final
      • params should be private

      BasicHttpProcessor
      requestInterceptors and responseInterceptors should be final
      Should also be private, otherwise subclasses can subvert the non-null condition

      Attachments

        1. threadsafety.patch
          3 kB
          Sebb

        Activity

          People

            Unassigned Unassigned
            sebb Sebb
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: