[HTTPCORE-103] DefaultNHttpServerConnection.consumeInput() stops reading

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.0-alpha5
• Fix Version/s: 4.0-alpha6
• Component/s: HttpCore NIO
• Assignee: Unassigned
• Reporter: Steffen Pingel
• Created: 17/Jul/07 20:51
• Updated: 11/Nov/07 19:19
• Resolved: 18/Jul/07 20:45

Description

If the underlying channel has more data buffered than can be read into inbuf DefaultNHttpServerConnection.consumeInput() will return and relies on the selector to timeout to read the remaining part of the request. I suggest to make the parsing code more greedy:

int bytesRead;
while ((bytesRead = this.requestParser.fillBuffer(this.session.channel())) > 0 && this.request == null) {
if (bytesRead > 0)

{ this.inTransportMetrics.incrementBytesTransferred(bytesRead); }

this.request = (HttpRequest) this.requestParser.parse();
}