[HTTPCLIENT-2292] SOCKS proxy configuration is not working

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 5.2.2
• Fix Version/s: 5.2.3, 5.3
• Component/s: HttpClient (classic)
• Assignee: Unassigned
• Reporter: Václav Kužel
• Created: 16/Aug/23 18:45
• Updated: 10/Jan/24 20:17
• Resolved: 15/Sep/23 09:37

Description

Current behaviour

A SOCKS proxy can be configured via the PoolingHttpClientConnectionManagerBuilder. setDefaultSocketConfig() method which accepts SocketConfig.setSocksProxyAddress(socksaddr) configuration.

*The socksProxyAddress configuration is ignored in class HttpClient*

Expected behaviour

• Proxy aware socket instances are instantiated by the Socket(Proxy proxy) constructor.
• Sockets are created via the ConnectionSocketFactory.createSocket() method.
• The DefaultHttpClientConnectionOperator.connect() method, which holds aforementioned configuration, calls the socket factory.

So, we need to pass the proxy address from the operator into the socket factory method.