[HTTPCLIENT-2190] HttpClientBuilder does not configure correctly the HttpClientConnectionManager

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Invalid
• Affects Version/s: 4.5.13
• Component/s: HttpClient (classic)
• Assignee: Unassigned
• Reporter: Marco Balieiro
• Created: 02/Dec/21 15:19
• Updated: 02/Dec/21 16:52
• Resolved: 02/Dec/21 16:52

Description

The class HttpClientBuilder does not configure correctly the HttpClientConnectionManager properties "maxTotal" and "defaultMaxPerRoute" if I already provided a ConnectionManager.

I sugest that the code on line 1000 should be put out of the "if" that tests if the "connManagerCopy" is null. Some think like this:

      if (connManagerCopy instanceof ConnPoolControl) {
            ConnPoolControl<?> connPoolControl = (ConnPoolControl<?>) connManagerCopy;
            if (systemProperties) {
                String s = System.getProperty("http.keepAlive", "true");
                if ("true".equalsIgnoreCase(s))

{                     s = System.getProperty("http.maxConnections", "5");                     final int max = Integer.parseInt(s);                     connPoolControl.setDefaultMaxPerRoute(max);                     connPoolControl.setMaxTotal(2 * max);                 }

            }
            if (maxConnTotal > 0)

{                 connPoolControl.setMaxTotal(maxConnTotal);             }

            if (maxConnPerRoute > 0)

{                 connPoolControl.setDefaultMaxPerRoute(maxConnPerRoute);             }

        }