[HTTPCLIENT-2157] Gzip decompression not applied with Apache CachingHttpClient version 5.0.3

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.0.3
• Fix Version/s: 5.0.4, 5.1
• Component/s: HttpClient (classic)
• Environment: Android
• Assignee: Unassigned
• Reporter: Gunther Heppner
• Created: 30/Apr/21 10:45
• Updated: 05/May/21 20:54
• Resolved: 01/May/21 16:08

Description

We are in the process of migrating from Apache HttpClient 4.5 to 5.0.3. Since we want to do client side http caching we are using CachingHttpClientBuilder to set up the HttpClient. With version 4.5.x this works fine and gzip-encoded responses are automatically decompressed. However, with version 5.0.3, the responses are returned as uncompressed ByteArrayEntity and the Conent-Encoding header is missing from the returned ByteArrayEntity, which prevents the default gzip decompression to be applied.

 

Note - I was able to get gzip decompression with the default HttpClient.

 

Steps to reproduce:

• Run this code with HttpClient 5.0.3
• Observe the ` responseString` returned from ` EntityUtils.toString()` in the ` HttpClientResponseHandler`, which will return a mangled string instead of a readable HTLM string

 

 
Based on some debugging, it looks like the bug might be in CachingExec.convert(), which generates a ClassicHttpResponse with a ByteArrayEntity from a cache entry, dropping the conent-encoding header in the process.