[HTTPCLIENT-2107] PoolingHttpClientConnectionManager unsafe volatile field access

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 5.0.1
• Fix Version/s: 5.0.2
• Assignee: Unassigned
• Reporter: Carter Kozak
• Created: 10/Aug/20 15:34
• Updated: 11/Aug/20 10:12
• Resolved: 11/Aug/20 10:12

Description

PoolingHttpClientConnectionManager assumes subsequent volatile reads on validateAfterInactivity and defaultSocketConfig result in the same value, which can result n incorrect assumptions or even null pointer exceptions.

We should read a snapshot to a local variable, and reuse the local snapshot.