[HTTPCLIENT-2084] HttpClientBuilder placing last HttpRequestInterceptor first

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 5.0
• Fix Version/s: 5.0.2
• Component/s: HttpClient (classic)
• Assignee: Unassigned
• Reporter: John Enters
• Created: 13/Jun/20 20:45
• Updated: 17/Jun/20 10:46
• Resolved: 17/Jun/20 10:46

Description

With the following:

CloseableHttpClient client = HttpClients.custom()
    .addRequestInterceptorFirst((request, entity, context) -> {
        System.out.println("This should be first");
    })
    .addRequestInterceptorLast((request, entity, context) -> {
        System.out.println("This should be last");
    })
    .build();

client.execute(new HttpGet("http://www.example.com"));

Result:

This should be last
This should be first

In org.apache.hc.client5.http.impl.classic.HttpClientBuilder

lines 830-832 adds the interceptor to the start of the list instead of the end.

if (entry.postion == RequestInterceptorEntry.Postion.LAST) {
    b.addFirst(entry.interceptor);
}

This should probably be the following:

if (entry.postion == RequestInterceptorEntry.Postion.LAST) {
    b.addLast(entry.interceptor); 
}