[HTTPCLIENT-2059] MinimalHttpAsyncClient does not allow null HttpContext

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 5.0
• Fix Version/s: 5.0.1
• Component/s: HttpClient (async)
• Assignee: Unassigned
• Reporter: Siqi Li
• Created: 05/Mar/20 22:50
• Updated: 06/Mar/20 22:06
• Resolved: 06/Mar/20 22:06

Description

In HttpAsyncClient.execute, the Javadoc says:

@param context HTTP context. Optional and may be {@code null}.

However, the following code will cause a NullPointerException because the input HttpContext is null:

  public static void main(String[] args) throws Exception {
    try (MinimalHttpAsyncClient client = HttpAsyncClients.createMinimal()) {
      client.start();
      client.execute(SimpleRequestProducer.create(SimpleHttpRequests.get("https://example.com")),
          SimpleResponseConsumer.create(), null, null, null).get();
    }
  }