[HTTPCLIENT-2040] Headers are not sent when following redirects

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 5.0 Beta6
• Fix Version/s: 5.0 Beta7
• Component/s: HttpClient (classic)
• Assignee: Unassigned
• Reporter: Jeff Schnitzer
• Created: 19/Dec/19 19:15
• Updated: 25/Dec/19 08:32
• Resolved: 25/Dec/19 08:32

Description

It appears that headers are not sent when following redirects.

RedirectExec.execute() contains this code:

 
                    switch (statusCode) {
                        case HttpStatus.SC_MOVED_PERMANENTLY:
                        case HttpStatus.SC_MOVED_TEMPORARILY:
                        case HttpStatus.SC_SEE_OTHER:
                            if (!Methods.isSafe(request.getMethod())) {
                                final HttpGet httpGet = new HttpGet(redirectUri);
                                httpGet.setHeaders(originalRequest.getHeaders());
                                redirect = httpGet;
                            } else {
                                redirect = null;
                            }
                    }
                    if (redirect == null) {
                        redirect = new BasicClassicHttpRequest(originalRequest.getMethod(), redirectUri);
                        redirect.setEntity(originalRequest.getEntity());
                    }
 

If the method is not 'safe' and converted to a GET, headers get copied from the original request. Otherwise, the original headers are silently dropped.

Desired behavior: Headers should always be copied from the original request. That was the behavior of HttpClient 4.x.