[HTTPCLIENT-1903] DefaultHostnameVerifier crashes on Android due to inexistent javax.naming classes

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.5.5
• Fix Version/s: 5.0 Beta2
• Assignee: Oleg Kalnichevski
• Reporter: Michael Pujos
• Created: 07/Feb/18 19:34
• Updated: 15/Aug/18 17:55
• Resolved: 08/Feb/18 18:57

Description

I'm using HttpClient on Android, repackaged to avoid conficting with the platform's org.apache old packages.

It works fine, except that making any https request will crash using the defaults.

The reason is that DefaultHostnameVerifier uses javax.naming.* classes, which are not present on Android.

So to be able to make https request, the default hostname verifier must be replaced. For example:

 

httpClient = HttpClients.custom()
                .setSSLHostnameVerifier(NoopHostnameVerifier.INSTANCE)

                .build();

 

Using NoopHostnameVerifier is rarely a good idea, so for the time being I have replaced it with and older version of BrowserCompatHostnameVerifier that doesn't internally call DefaultHostnameVerifier.

 

Ideally, I'd like DefaultHostnameVerifier to detect dynamically if javax.naming.* classes are available, and switch to an alternate method not using them if they are not. That way, HttpClient would work out of the box for Android users.