[HTTPCLIENT-1835] evictExpiredConnections does not work as intended

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.5.4, 5.0 Alpha3
• Fix Version/s: 4.5.4, 5.0 Alpha2
• Component/s: HttpClient (async), HttpClient (classic)
• Assignee: Unassigned
• Reporter: Liam Williams
• Created: 20/Mar/17 21:32
• Updated: 15/Aug/18 17:55
• Resolved: 22/Mar/17 09:20

Description

HttpClientBuilder and HttpAsyncClientBuilder have an evictExpiredConnections method that is supposed to allow configuring a client that will evict expired connections.

When evictExpiredConnections is used alongside evictIdleConnections, everything is fine.

However, if evictExpiredConnections is used without evictIdleConnections, currently the builder will default to also providing the evictIdleConnections behaviour (defaulting to evicting idle connections after 10 seconds).

The correct behaviour in this case is to only provide the evictExpiredConnections behaviour and not the evictIdleConnections behaviour.

Issue Links

• breaks: HTTPCLIENT-1583 Add option to create a connection eviction thread for a non-shared connection manager
• links to: GitHub Pull Request #70
• links to: GitHub Pull Request #71
• links to: GitHub Pull Request #72