Uploaded image for project: 'HttpComponents HttpClient'
  1. HttpComponents HttpClient
  2. HTTPCLIENT-1803

Malformed path not handled well

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

      Description

      When using URIBuilder's constructor with a malformed url argument, host passed in by setHost call not honored.

      String path = "@notexample.com/mypath"
      URI uri = new URIBuilder(path).setHost("example.com").build();
      org.junit.Assert.assertEquals("example.com", uri.getHost())

      This is caused by the original string being passed into the constructor being treated as the path, but not verifying the presence of a leading / character.
      This can be seen with other arguments:

      path = "example" -> //example.comexample

      Fix: URIBuilder should ensure path starts with a leading /.

      Reason priority is considered Major:
      In our case, this caused a security vulnerability which was discovered by researcher James Kettle (@albinowax on twitter). The user-provided path was able to override our specified host, resulting in giving network access to a sensitive environment. We worked around this in our code by ensuring the leading /, but this seems like something better handled by the framework.

      PS. If you agree this should be fixed, I'm happy to submit a pull request.

        Attachments

        Issue Links

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              tylerbenson Tyler Benson

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment