[HTTPCLIENT-1801] HttpRequestBase.releaseConnection() method aborts connection rather than release it

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.5.2
• Fix Version/s: 5.0 Alpha2
• Component/s: HttpClient (classic)
• Labels: method releaseConnection rename
• Assignee: Unassigned
• Reporter: Daniel Isaac Khan Ramiro
• Created: 07/Jan/17 22:58
• Updated: 09/Jan/17 16:46
• Resolved: 09/Jan/17 16:46

Description

Trying to release any HTTP method that extends org.apache.hc.client5.http.methods.HttpRequestBase, for example:

Package: org.apache.hc.client5.http.methods
HttpGet get = new HttpGet();
get.releaseConnection();

will result into the connection being aborted and therefore instead of being released it will be removed completely from the pool of connections since the method called eventually within the org.apache.hc.client5.http.impl.sync.ConnectionHolder object (Cancellable) would be cancel() which would in turn abortConnection()

The name of the method is misleading as the implementation of releaseConnection does not do what it claims, but rather it resets the connection.