[HTTPCLIENT-1761] Missing null check in parse method

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 4.4.1, 4.5, 4.5.1, 4.5.2
• Fix Version/s: 4.5.3
• Flags: Patch
• Assignee: Unassigned
• Reporter: Thomas Feiner
• Created: 10/Aug/16 14:20
• Updated: 13/Aug/16 19:20
• Resolved: 13/Aug/16 19:20

Description

While in org.apache.http.client.utils.URLEncodedUtils the method

public static List<NameValuePair> parse(String s, Charset charset, char... separators)

has a null check for String "s", this method has no null check:

public static List<NameValuePair> parse(String s, Charset charset)

For consistency and backward compatibility reasons I recommend adding a null check there.

Furthermore I would delegate to the method with separators:

public static List<NameValuePair> parse(String s, Charset charset) {
        return URLEncodedUtils.parse(s, charset, '&', ';');
} 

Issue Links

• duplicates: HTTPCLIENT-1746 URLEncodedUtils.parse(String, CharSet) in 4.4 causes an NPE on null input and is not backward compatible