[HTTPCLIENT-1605] Cannot upload files with HttpClient 4.3.6 using PUT/POST

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.3.6
• Fix Version/s: 4.4 Final
• Component/s: HttpClient (classic)
• Labels: easyfix
• Assignee: Unassigned
• Reporter: Svetlin Zarev
• Created: 27/Jan/15 09:59
• Updated: 27/Jan/15 12:07
• Resolved: 27/Jan/15 10:41

Description

Affected component: HttpClient 4.3.6
Class: org.apache.http.client.entity.EntityBuilder

When building a new HttpEntity using the EntityBuilder, the method EntityBuilder.setStream() always sets the content length of the stream to 1, which causes http PUT/POST requests to upload only 1 byte, instead of the whole content of the stream.

Line 319:

if (this.stream != null) {
            e = new InputStreamEntity(this.stream, 1, getContentOrDefault(ContentType.DEFAULT_BINARY));
        }

It should be:

if (this.stream != null) {
            e = new InputStreamEntity(this.stream, -1, getContentOrDefault(ContentType.DEFAULT_BINARY));
        }