[HTTPCLIENT-1544] NPE in formatCooke method while parsing response cookies

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.3.5
• Fix Version/s: 4.3.6, 4.4 Beta1
• Component/s: HttpClient (classic)
• Environment: Java 8, OS X
• Assignee: Unassigned
• Reporter: Mike Houston
• Created: 15/Aug/14 18:30
• Updated: 04/May/17 09:49
• Resolved: 16/Aug/14 11:12

Description

Null pointer exception if value of cookie is null during log formatting:

<line ResponseProcessCookies:139>
String v = cookie.getValue();
        if (v.length() > 100) { // <== NPE

java.lang.NullPointerException
	at org.apache.http.client.protocol.ResponseProcessCookies.formatCooke(ResponseProcessCookies.java:140)
	at org.apache.http.client.protocol.ResponseProcessCookies.processCookies(ResponseProcessCookies.java:117)
	at org.apache.http.client.protocol.ResponseProcessCookies.process(ResponseProcessCookies.java:91)
	at org.apache.http.protocol.ImmutableHttpProcessor.process(ImmutableHttpProcessor.java:139)
	at org.apache.http.impl.nio.client.MainClientExec.responseReceived(MainClientExec.java:306)
	at org.apache.http.impl.nio.client.DefaultClientExchangeHandlerImpl.responseReceived(DefaultClientExchangeHandlerImpl.java:148)
	at org.apache.http.nio.protocol.HttpAsyncRequestExecutor.responseReceived(HttpAsyncRequestExecutor.java:224)
	at org.apache.http.impl.nio.client.LoggingAsyncRequestExecutor.responseReceived(LoggingAsyncRequestExecutor.java:112)
	at org.apache.http.impl.nio.DefaultNHttpClientConnection.consumeInput(DefaultNHttpClientConnection.java:254)
	at org.apache.http.impl.nio.client.InternalIODispatch.onInputReady(InternalIODispatch.java:73)
	at org.apache.http.impl.nio.client.InternalIODispatch.onInputReady(InternalIODispatch.java:37)
	at org.apache.http.impl.nio.reactor.AbstractIODispatch.inputReady(AbstractIODispatch.java:113)
	at org.apache.http.impl.nio.reactor.BaseIOReactor.readable(BaseIOReactor.java:159)
	at org.apache.http.impl.nio.reactor.AbstractIOReactor.processEvent(AbstractIOReactor.java:338)
	at org.apache.http.impl.nio.reactor.AbstractIOReactor.processEvents(AbstractIOReactor.java:316)
	at org.apache.http.impl.nio.reactor.AbstractIOReactor.execute(AbstractIOReactor.java:277)
	at org.apache.http.impl.nio.reactor.BaseIOReactor.execute(BaseIOReactor.java:105)
	at org.apache.http.impl.nio.reactor.AbstractMultiworkerIOReactor$Worker.run(AbstractMultiworkerIOReactor.java:584)
	at java.lang.Thread.run(Thread.java:724)