[HTTPCLIENT-1347] gzip responses doubly cached

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.2.5
• Fix Version/s: 5.4-alpha1
• Component/s: HttpCache
• Labels: stuck volunteers-wanted
• Environment: ARCH Linux kernel 3.8.8-1; node.js 0.8.22
• Assignee: Unassigned
• Reporter: Adam Patacchiola
• Created: 25/Apr/13 13:11
• Updated: 28/Nov/23 16:37
• Resolved: 21/Jun/23 07:12

Description

Compressed responses are cached twice.

Run the attached server (node.js 0.8.22) and client tests. Create an "assets" directory under where you are running the server and add two files named 1 and 2 ( < 1000000 bytes) . You will see that after the test is run the cache dump output displays 2 sets of entries for each request, each containing the full content length of the file.

Changing the implementation of HttpCacheStorage updateEntry to not update non existent entries (as I believe the correct implementation should do) throws exceptions.