[HTTPCLIENT-1325] Using a HttpRequest that is not an HttpUriRequest when host in URI is not target host results in an invalid request

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.3 Alpha1
• Fix Version/s: 4.3 Beta1
• Component/s: HttpClient (classic)
• Assignee: Unassigned
• Reporter: Francois-Xavier Bonnet
• Created: 21/Feb/13 14:09
• Updated: 05/Oct/13 19:41
• Resolved: 22/Feb/13 08:44

Description

Using the following code:
CloseableHttpClient httpClient = HttpClientBuilder.create().build();
HttpHost httpHost = new HttpHost("127.0.0.1", 80, "http");
HttpRequest request = new BasicHttpRequest("GET", "http://www.foo.com/test");
httpClient.execute(httpHost, request);

HttpClient sends this request:
GET http://www.foo.com/test HTTP/1.1
Host: 127.0.0.1:80
Connection: Keep-Alive
User-Agent: Apache-HttpClient/4.3-alpha2-SNAPSHOT (java 1.5)
Accept-Encoding: gzip,deflate

The host header is not consistent with the request URI. This is due to org.apache.http.impl.execchain.ProtocolExec:

HttpHost target = null;
if (virtualHost != null)

{ target = virtualHost; }

else {
final HttpRequest original = request.getOriginal();
if (original instanceof HttpUriRequest) {
final URI uri = ((HttpUriRequest) original).getURI();
if (uri.isAbsolute())

{ target = new HttpHost(uri.getHost(), uri.getPort(), uri.getScheme()); }

}
}
if (target == null)

{ target = route.getTargetHost(); }

So for a HttpUriRequest the host is taken from the URI but for other requests it is taken from the target server.
I think it should be taken from the target server only if it cannot be determined from the URI (non-absolute URI).

I will fix this.