[HTTPCLIENT-1314] Deadlock in http.client.fluent.Async.ExecRunnable.run() if there is an exception in FutureCallback

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 4.2.3, 4.3 Alpha1
• Component/s: HttpClient (classic)
• Labels: fluent httpclient
• Environment: Windows 7 64bits
• Assignee: Unassigned
• Reporter: Andrey P
• Created: 01/Feb/13 01:42
• Updated: 05/Oct/13 19:41
• Resolved: 01/Feb/13 13:04

Description

Deadlock in http.client.fluent.Async.ExecRunnable.run() if an exception is thrown in FutureCallback.completed()
Look at the <<<http.client.fluent.Async.ExecRunnable.run()>>> method:
public void run() {
try

{ Response response = this.executor.execute(this.request); T result = response.handleResponse(this.handler); this.future.completed(result); }

catch (Exception ex)

{ **** this is never called because the BasicFuture.completed flag is set to true BEFORE the callback invocation **** (see below) this.future.failed(ex); }

}

<<<http.concurrent.BasicFuture>>>
public synchronized boolean completed(final T result) {
if (this.completed)

{ return false; }
this.completed = true;
this.result = result;
if (this.callback != null) { this.callback.completed(result); }
*** not executed if an exception in the callback.completed()
notifyAll();
return true;
}
public synchronized boolean failed(final Exception exception) {
if (this.completed) { return false; }

• • • the following can't be reached if there is an exception in this.callback.completed() so that
    • BasicFuture.get() waits forever

this.completed = true;
this.ex = exception;
if (this.callback != null)

{ this.callback.failed(exception); }

notifyAll();
return true;
}

Issue Links

• duplicates: HTTPCORE-331 deadlock in AbstractNIOConnPool