[HTTPCLIENT-1296] Null pointer exception when using default host and virtual host with port -1

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 4.2.2
• Fix Version/s: 4.2.3
• Assignee: Karl Wright
• Reporter: Karl Wright
• Created: 10/Jan/13 00:52
• Updated: 05/Oct/13 19:42
• Resolved: 10/Jan/13 11:28

Description

The following code in DefaultRequestDirector is incorrect:

        // HTTPCLIENT-1092 - add the port if necessary
        if (virtualHost != null && virtualHost.getPort() == -1) {
            int port = target.getPort();
            if (port != -1){
                virtualHost = new HttpHost(virtualHost.getHostName(), port, virtualHost.getSchemeName());
            }
        }

The reason it is incorrect is that if the target has not been specified in the URL, then an NPE will result. The target is resolved later in the same method in that case.