[HTTPCLIENT-1285] InternalHttpClient.doExecute() clobbers context request config

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.3 Alpha1
• Assignee: Unassigned
• Reporter: Noah Levitt
• Created: 29/Dec/12 09:36
• Updated: 05/Oct/13 19:42
• Resolved: 31/Dec/12 17:08

Description

In InternalHttpClient.doExecute() even if HttpClientContext requestConfig has been set, it gets replaced. Not sure what the intent is here as far as which config should take precedence, but if "request" doesn't provide a RequestConfig, I would certainly expect the HttpClientContext requestConfig to carry through.

HttpClientContext localcontext = setupContext(context);
HttpRoute route = determineRoute(target, wrapper, localcontext);
RequestConfig config = null;
if (request instanceof Configurable)

{ config = ((Configurable) request).getConfig(); }

if (config == null)

{ config = this.defaultConfig; }

if (config == null)

{ config = HttpClientParamConfig.getRequestConfig(params); }

localcontext.setRequestConfig(config);

This is in trunk as of r1414680